fix: DateInput and Actions button not optimised for mobile viewports #9432
Conversation
WalkthroughThis pull request addresses mobile viewport optimization for the DateInput component and the Patient Home page. The changes focus on improving the responsiveness of the date picker dropdown in the Changes
Assessment against linked issues
Sequence DiagramsequenceDiagram
participant User
participant DateInputV2
participant PatientHome
User->>DateInputV2: Interact with Date Picker
DateInputV2->>DateInputV2: Adjust Positioning
User->>PatientHome: Select Volunteer
PatientHome->>UserAutocomplete: Choose User
UserAutocomplete->>PatientHome: Update Assigned Volunteer
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/components/Common/DateInputV2.tsx (1)
291-291: LGTM! Consider consolidating duplicate responsive classes.The responsive positioning classes effectively handle the date picker's position across different viewport sizes. However, there's a minor optimization opportunity.
Consider consolidating the duplicate translation classes:
-return `${right ? "sm:-translate-x-1/2" : ""} ${top ? "md:-translate-y-[calc(100%+50px)]" : ""} ${right ? "max-sm:-translate-x-1/2" : ""} ${top ? "max-sm:-translate-y-[calc(100%+50px)]" : ""}`.trim(); +return `${right ? "-translate-x-1/2" : ""} ${top ? "-translate-y-[calc(100%+50px)]" : ""}`.trim();The simplified version achieves the same responsive behavior since the translation will apply across all screen sizes, which is what we want for both cases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/Common/DateInputV2.tsx(1 hunks)src/components/Patient/PatientHome.tsx(1 hunks)
🔇 Additional comments (1)
src/components/Patient/PatientHome.tsx (1)
455-455: LGTM! Improved mobile layout with centered alignment.
The change from mx-3 to mx-auto effectively centers the actions section, providing better visual balance on mobile viewports.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
DateInputV2component for improved responsive design.UserAutocompletecomponent in thePatientHomefor volunteer selection.Bug Fixes
PatientHomecomponent for better alignment.